Skip to content

chore(tools): update tooling config for v6 prefix#3132

Merged
bennypowers merged 11 commits into
staging/pfv6from
chore/v6-tooling-config
May 10, 2026
Merged

chore(tools): update tooling config for v6 prefix#3132
bennypowers merged 11 commits into
staging/pfv6from
chore/v6-tooling-config

Conversation

@zeroedin
Copy link
Copy Markdown
Collaborator

@zeroedin zeroedin commented May 8, 2026 •
edited
Loading

Summary

Phase 0.2

  • Generalize eslint ignore glob for icon demo path to handle both pf-v5-icon and pf-v6-icon
  • Update eslint no-missing-package-exports rule to match only pf-v6-* element directories
  • Remove all pf-v5-* export entries from elements/package.json — v6 release will not ship v5 elements
  • Bump elements package version to 6.0.0-next.0
  • Audited tsconfig, web-test-runner, playwright, and commitlint configs — no changes needed

Closes #3130

@zeroedin
chore(tools): update tooling config for v6 prefix
bf4d33f 
- Generalize eslint ignore glob for icon demo path to match both
  pf-v5-icon and pf-v6-icon directories
- Update eslint no-missing-package-exports rule to match only pf-v6-*
  element directories
- Remove all pf-v5-* export entries from elements/package.json since
  v6 release will not ship v5 elements
- Bump elements package version to 6.0.0-next.0

Audited and confirmed no changes needed in:
- tsconfig files (no v5-specific paths)
- web-test-runner.config.js (generic globs)
- playwright.config.ts (generic globs)
- commitlint.config.js (already handles both prefixes dynamically)

Closes #3130

Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 21ec196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026 •
edited
Loading

✅ Commitlint tests passed!

More Info 
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "chore(tools): update tooling config for v6 prefix"
}

@github-actions github-actions Bot added the AT passed Automated testing has passed label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 00addfb
😎 Deploy Preview https://deploy-preview-3132--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

SSR Test Run for 696ee2f: Report

@zeroedin zeroedin requested a review from bennypowers May 8, 2026 17:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

SSR Test Run for 142c53e: Report

@zeroedin
Copy link
Copy Markdown
Collaborator Author

zeroedin commented May 8, 2026

@bennypowers, we have a .config/cem.yaml in the elements dir, and another in the root. It is my assumption that the one in the elements dir needs to be removed. Not sure why that wouldn't just sit at the root? It was causing problems with the agents running. Thoughts?

bennypowers
bennypowers requested changes May 10, 2026
View reviewed changes
Comment thread .config/cem.yaml Outdated
Comment thread elements/package.json Outdated
Comment thread eslint.config.js Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

SSR Test Run for 00addfb: Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

SSR Test Run for eb8dd99: Report

@bennypowers bennypowers merged commit f88f79e into staging/pfv6 May 10, 2026
11 checks passed
@bennypowers bennypowers deleted the chore/v6-tooling-config branch May 10, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers requested changes

Assignees

No one assigned

Labels

AT passed Automated testing has passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeroedin @bennypowers